Conversation
epicsam123
requested review from
a team,
SamantazFox and
unixfox
as code owners
| 2019-01-19 16:37:54 +00:00 200 GET /watch 7.04ms</code></pre> | ||
| <p>This website does not store the visitor's user-agent or IP address and does not use fingerprinting, advertisements, or tracking of any form.</p> | ||
| <p>This website provides links to googlevideo.com to provide audio and video playback. googlevideo.com is owned by Google and is subject to their <a href="https://policies.google.com/privacy">privacy policy</a>.</p> | ||
| <p>This website provides links to googlevideo.com to provide audio and video playback. googlevideo.com is owned by Google and is subject to their <a rel="noopener noreferrer" href="https://policies.google.com/privacy">privacy policy</a>.</p> |
There was a problem hiding this comment.
There are other external links that I didn't modify. Should we consider those as well?
locales/ar.json
Outdated
| "preferences_thin_mode_label": "الوضع الخفيف: ", | ||
| "preferences_category_misc": "تفضيلات متنوعة", | ||
| "preferences_automatic_instance_redirect_label": "إعادة توجيه المثيل التلقائي (إعادة التوجيه إلى redirect.invidious.io): ", | ||
| "preferences_include_youtube_links_label": "عرض روابط إعادة التوجيه على يوتيوب: ", |
There was a problem hiding this comment.
You only need to provide translations for en-US.
Other translations are done through weblate (ex: https://github.com/iv-org/invidious/pull/4989/files ).
|
Although not mutually exclusive, this PR does overlap and change the same sections of code as #4826, which adds a confirmation page before visiting YouTube links. I'm not sure if I personally agree with adding more code to remove the links from the frontend—which can increase the maintenance burden—when a confirmation page will serve the same purpose for safeguarding against tracking. @SamantazFox @unixfox what do you think? |
|
@syeopite I'm in favor of the confirmation page proposed in that other pull request. I agress that we already have enough config options like that. |
|
Will close this in favor of #4826, thanks! |
4 participants
I use Invidious mainly for preventing Google tracking. As a user, I thought it would be nice to include the option to hide YT links in the UI as I sometimes accidentally click on them (primarily the comment links when on mobile). I also included some missing "noreferrers".
Translations were provided by perplexity.ai