Merged
Conversation
Fijxu
commented
Feb 18, 2025
| private KNOWN_TABS = { | ||
| "home", "videos", "shorts", "streams", "podcasts", | ||
| "releases", "playlists", "community", "channels", "about", | ||
| "posts", |
Member
Author
There was a problem hiding this comment.
Here I didn't replace "community" by "posts". I left it as a fallback.
syeopite
reviewed
Feb 18, 2025
syeopite
approved these changes
Feb 18, 2025
Contributor
|
Suggestion: Since the url didn't change and just the text, maybe this can be handled similarly to how channel live tab is handled? (1 ternary statement that changes invidious/src/invidious/channels/about.cr Lines 105 to 112 in 164d764 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May close #5182
API works well too.
If I need to change anything, just tell me