Fix an issue with the HLS manifest check for livestream videos

[alexmaras]

Originally, the HLS manifest check was essentially a boolean: if the HLS manifest field was present, it was assumed to be a livestream. Some videos include the HLS Manifest but aren't livestreams.

In the case where they are livestreams, the video contains a videoType field with the value "Livestream". In the case that they're normal videos, the videoType is "Video". This is exposed via the video.live_now method.

This commit just checks that video.live_now is true before treating it as a livestream

[alexmaras]

Fixes: iv-org/invidious-companion#35

There's also another place where the simple check for an HLS manifest exists:

invidious/src/invidious/jsonify/api_v1/video_json.cr

Line 72 in 164d764

if hlsvp = video.hls_manifest_url

Does this also need to be changed?

The alternative approach to this would be to add a boolean property to the video - video.is_livestream? which can resolve to a boolean and centralise that check. Happy to adjust and take that approach.

This change has been tested on my local instance and is working well with:

• videos that have an hls_manifest_url but aren't a livestream
• videos that have an hls_manifest_url and are a livestream
• videos that don't have an hls_manifest_url

Let me know if anything makes sense to change.

[syeopite]

You should just be able to check whether video.live_now is true instead of the URL

[alexmaras]

Thanks - great catch. I'm still digging through the codebase, this does a better job that checking the URL.

I've updated to that in case it's worth merging this in in the meantime as some videos are broken at the moment.

[syeopite]

If I'm understanding everything correctly this is something that should be fixed by #4118, whenever that is merged.

This part of the PR prevents Invidious's frontend from using the HLS manifest unless the video is a livestream or the user has selected HLS quality

invidious/src/invidious/views/components/player.ecr

Lines 7 to 10 in ffc44b0

	<% if (hlsvp = video.hls_manifest_url) && video.live_now && !CONFIG.disabled?("livestreams") %>
	<source src="<%= URI.parse(hlsvp).request_target %><% if params.local %>?local=true<% end %>" type="application/x-mpegURL" label="<%= HTML.escape(translate(locale,"video_quality_livestream_label")) %>">
	<% elsif (hlsvp = video.hls_manifest_url) && params.quality == "hls" && !CONFIG.disabled?("hls") %>
	<source src="<%= URI.parse(hlsvp).request_target %><% if params.local %>?local=true<% end %>" type="application/x-mpegURL" label="<%= HTML.escape(translate(locale,"video_quality_hls_label")) %>">

[alexmaras]

Thanks @syeopite - yep, looks like the fix in #4118 covers this completely. If that one is still a little while away, this fixes the issue for the moment until that PR gets merged in. I've amended the commit to handle the issue using the video.live_now method instead.