fix: restore dmca_content functionality#5228
Conversation
syeopite
left a comment
There was a problem hiding this comment.
The dmca_content config was originally just used to disable the download widget for specific videos
Seems like the configuration check was forgotten when the download widget and logic was extracted from watch.ecr in #2922
I don't really have any particular opinion on whether this should be restored or not, or whether the api should be affected.
But if this attribute is expanded to encompass the /watch page then the documentation in config.example.yml and config.cr needs to be updated
This restores (or adds) the functionality of the `dmca_content` config option that at this date, has been unused and makes no effect.
|
That should be fine. That restores the original functionality of what I think is a great idea to add an option to block the whole video and not just the download, because instance administrators that are forced to comply with DMCA, will have not have an option to block the videos directly on Invidious and instead they will need to block it at the webserver level |
syeopite
left a comment
There was a problem hiding this comment.
Good for merging as-is.
For now I think we should at least fix this rather big bug of an entire config option being broken before talking about expanding it.
Could you please make an issue for that?
Yep, indeed.
I don't see why the API would be affected? This option only removes the easy download option, but it doesn't prenvent video playback. In all cases, people making DMCA requests should be redirected to youtube, as we're not hosting any content, and thus unable to remove it from there. |
|
@SamantazFox We leave it like this or we also disable it from the API? Every public instance already has their API disabled and is impossible to keep it enabled, otherwise it will just be abused and rate limit the instance |

This restores (or adds) the functionality of the
dmca_contentconfig option that at this date, has been unused and makes no effect.I prefer to leave it enabled only for the frontend, I'm not sure about the API, so tell me what do you guys (iv-org) prefer