Skip to content

fix: restore dmca_content functionality#5228

Merged
Fijxu merged 2 commits intoiv-org:masterfrom
Fijxu:dmca_content-fix
Dec 6, 2025
Merged

fix: restore dmca_content functionality#5228
Fijxu merged 2 commits intoiv-org:masterfrom
Fijxu:dmca_content-fix

Conversation

@Fijxu
Copy link
Copy Markdown
Member

@Fijxu Fijxu commented Apr 1, 2025

This restores (or adds) the functionality of the dmca_content config option that at this date, has been unused and makes no effect.

I prefer to leave it enabled only for the frontend, I'm not sure about the API, so tell me what do you guys (iv-org) prefer

@Fijxu Fijxu requested review from a team and SamantazFox as code owners April 1, 2025 01:51
Copy link
Copy Markdown
Member

@syeopite syeopite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dmca_content config was originally just used to disable the download widget for specific videos

Seems like the configuration check was forgotten when the download widget and logic was extracted from watch.ecr in #2922


I don't really have any particular opinion on whether this should be restored or not, or whether the api should be affected.

But if this attribute is expanded to encompass the /watch page then the documentation in config.example.yml and config.cr needs to be updated

Fijxu added 2 commits June 12, 2025 19:05
This restores (or adds) the functionality of the `dmca_content` config
option that at this date, has been unused and makes no effect.
@Fijxu Fijxu force-pushed the dmca_content-fix branch from ab862e0 to a218dad Compare June 12, 2025 23:14
@Fijxu
Copy link
Copy Markdown
Member Author

Fijxu commented Jun 12, 2025

That should be fine. That restores the original functionality of what dmca_content setting used to do. I've also added a message showing the reason why (since the setting is called dmca_content)

image

I think is a great idea to add an option to block the whole video and not just the download, because instance administrators that are forced to comply with DMCA, will have not have an option to block the videos directly on Invidious and instead they will need to block it at the webserver level

Copy link
Copy Markdown
Member

@syeopite syeopite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for merging as-is.

For now I think we should at least fix this rather big bug of an entire config option being broken before talking about expanding it.

Could you please make an issue for that?

@syeopite syeopite added the ready label Sep 8, 2025
@SamantazFox
Copy link
Copy Markdown
Member

Seems like the configuration check was forgotten when the download widget and logic was extracted from watch.ecr in #2922

Yep, indeed.

I don't really have any particular opinion on whether this should be restored or not, or whether the api should be affected.

I don't see why the API would be affected? This option only removes the easy download option, but it doesn't prenvent video playback.

In all cases, people making DMCA requests should be redirected to youtube, as we're not hosting any content, and thus unable to remove it from there.

@Fijxu
Copy link
Copy Markdown
Member Author

Fijxu commented Oct 16, 2025

@SamantazFox We leave it like this or we also disable it from the API? Every public instance already has their API disabled and is impossible to keep it enabled, otherwise it will just be abused and rate limit the instance

@Fijxu Fijxu merged commit a7935bc into iv-org:master Dec 6, 2025
8 of 9 checks passed
@syeopite syeopite added this to the Next release milestone Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants