Add ability to view video transcripts to the Invidious frontend #5298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a server-side UI template that renders a transcript element. This is used to render transcripts for users without JS.
Innertube structure was changed
|
|
||
| addEventListener("DOMContentLoaded", () => { | ||
| const transcriptLines = document.getElementById("lines"); | ||
| for (const transcriptLine of transcriptLines.children) { |
There was a problem hiding this comment.
I'd recommend adding the click event listener on transcriptLines and checking the event's target. This would have better performance than adding an event listener onto each transcriptLine
| @@ -195,3 +195,15 @@ addEventListener('load', function (e) { | |||
| comments.innerHTML = ''; | |||
| } | |||
| }); | |||
|
|
|||
| addEventListener("DOMContentLoaded", () => { | |||
There was a problem hiding this comment.
I don't remember if internet explorer is still a supported browser or not but arrow functions aren't supported in IE. So if it is still supported it will need to be changed. https://caniuse.com/arrow-functions
Suggested change
| addEventListener("DOMContentLoaded", () => { | |
| addEventListener("DOMContentLoaded", function() { |
Fijxu
reviewed
May 13, 2025
| margin: 0; | ||
| } | ||
|
|
||
| .transcript-line:hover, .selected.transcript-line, .transcript-title-line:hover, .selected.transcript-title-line { |
There was a problem hiding this comment.
Hovering looks great on light mode, but it doesn't look great on dark mode (the default used by invidious).
Suggested change
| .transcript-line:hover, .selected.transcript-line, .transcript-title-line:hover, .selected.transcript-title-line { | |
| .transcript-line:hover, .selected.transcript-line, .transcript-title-line:hover, .selected.transcript-title-line { | |
| background: #4f4f4f; | |
| } | |
| .light-theme .transcript-line:hover, .selected.transcript-line, .transcript-title-line:hover, .selected.transcript-title-line { | |
| background: #cacaca; | |
| } |
With the suggestion, it now looks like this:
|
In testing on https://inv.nadeko.net with my CSS suggestion applied |
R0gu3h3h3h3
pushed a commit
to R0gu3h3h3h3/oiia
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2564
The current description box isn't really designed to hold non preformatted content hence the extraneous spacing at the bottom. Once #4111 is merged the description box should get a redesign to better accommodate these description widgets and how they should be affected by the expand description user preference.