Skip to content

CI: Fix docker ci job not checking if Invidious starts successfully or not #5306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: use-arm64-runner
Choose a base branch
from

Conversation

Fijxu
Copy link
Member

@Fijxu Fijxu commented May 15, 2025

Depends on #5305

As discussed on #5305 (comment), we noticed that the build-docker job doesn't actually checks if Invidious works or not, because curl always exited with code 0 (success) and the current docker-compose.yml files has defaults that will make Invidious fail at start (hmac_key missing).

@Fijxu Fijxu requested review from unixfox and a team as code owners May 15, 2025 20:47
@Fijxu Fijxu force-pushed the fix-build-docker branch 3 times, most recently from 7fadbd5 to 01c6c2e Compare May 15, 2025 21:59
Copy link
Member

@syeopite syeopite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just have a single documentation request left

@Fijxu Fijxu force-pushed the fix-build-docker branch 2 times, most recently from ffa8de5 to 2a8d690 Compare May 15, 2025 23:53
@Fijxu Fijxu force-pushed the fix-build-docker branch from 2a8d690 to cc643f2 Compare May 15, 2025 23:57
@syeopite syeopite added the type:container Docker/k8s/helm label May 18, 2025
@syeopite syeopite added the ready label Jun 12, 2025
@syeopite syeopite changed the title CI: Fix build-docker job not checking if Invidious starts successfully or not CI: Fix docker ci job not checking if Invidious starts successfully or not Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants