Make base-Invidious video info extraction more resilient #5312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try next fallback client if one raises Convert `dig` to `dig?` Optimize companionless stream retrieval
This was referenced May 18, 2025
Member
😄 👍 |
Fijxu
approved these changes
May 18, 2025
Member
Fijxu
left a comment
Fijxu
left a comment
There was a problem hiding this comment.
Works fine. I no longer get Missing hash key: "videoDetails" (KeyError) when I don't have inv_sig_helper nor invidious-companion set up on the config. The video just fails to play.
2025-05-18 21:24:52 UTC [warn] Missing URLs for adaptive formats, falling back to other YT clients.
2025-05-18 21:24:52 UTC [debug] try_fetch_streaming_data: [x] Using TvHtml5 client.
2025-05-18 21:24:52 UTC [debug] YoutubeAPI: Using endpoint: "/youtubei/v1/player"
2025-05-18 21:24:52 UTC [debug] try_fetch_streaming_data: [x] Got playabilityStatus == LOGIN_REQUIRED.
2025-05-18 21:24:52 UTC [warn] Failed to fetch streams with TvHtml5
2025-05-18 21:24:52 UTC [debug] try_fetch_streaming_data: [x] Using WebMobile client.
2025-05-18 21:24:52 UTC [debug] YoutubeAPI: Using endpoint: "/youtubei/v1/player"
2025-05-18 21:24:52 UTC [debug] try_fetch_streaming_data: [x] Got playabilityStatus == OK.
syeopite
changed the title
Member
|
Do we still candidate this PR for fixing #5307? |
Member
Author
|
Yeah it's just a title change |
NorkzYT
pushed a commit
to NorkzYT/invidious
that referenced
this pull request
Nov 16, 2025
Try next fallback client if one raises Convert `dig` to `dig?` Optimize companionless stream retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5307
Try next fallback client if one raises
Convert
digtodig?Optimize companionless stream retrieval
At this point the usage of
dig?should just be mandatory lolThis PR makes the companion-less stream retrieval logic slightly faster, and more resilient. Some calls to
#digis also replaced with#dig?src/invidious/videos/parser.cris a bit of a mess and there a ton of duplicated errors too. I'll see if I can do a clean-up after we upgrade to Kemal 1.7.0 and maybe after #5237