YtAPI: Bump client versions #5325
Conversation
Co-authored-by: syeopite <[email protected]>
|
That should be ok, Invidious uses a more updated IOS version than the one being used on youtube.js, should work fine tho, but I haven't tested it since Invidious doesn't use the IOS client at all. |
There was a problem hiding this comment.
Looks good to me. I'd like to wait for a review from @SamantazFox first before merging in case there's some nuances I missed.
| private IOS_USER_AGENT = "com.google.ios.youtube/#{IOS_APP_VERSION} (iPhone14,5; U; CPU iOS 17_6 like Mac OS X;)" | ||
| private IOS_VERSION = "17.6.1.21G93" # Major.Minor.Patch.Build |
There was a problem hiding this comment.
The IOS version itself could probably also be increased.
| private IOS_USER_AGENT = "com.google.ios.youtube/#{IOS_APP_VERSION} (iPhone14,5; U; CPU iOS 17_6 like Mac OS X;)" | |
| private IOS_VERSION = "17.6.1.21G93" # Major.Minor.Patch.Build | |
| private IOS_USER_AGENT = "com.google.ios.youtube/#{IOS_APP_VERSION} (iPhone14,5; U; CPU iOS 18_5 like Mac OS X;)" | |
| private IOS_VERSION = "18.5.0.22F76" # Major.Minor.Patch.Build |
There was a problem hiding this comment.
Do note though that the future of Invidious is going to be through companion only which has its own versions, using youtube.js. And the main Invidious will mainly use the WEB client.
There was a problem hiding this comment.
Are we also planning on migrating InnerTube requests for non /player endpoints to companion as well? Because if not I can at least still see some possible scenarios where we'll need to use the other clients to fetch certain data from YouTube if they decide to remove it from the WEB client for example.
There was a problem hiding this comment.
Are we also planning on migrating InnerTube requests for non /player endpoints to companion as well?
I don't think that is necessary until it gets hard to maintain due to blockages on other parts of Youtube other than trying to watch a video
| private ANDROID_APP_VERSION = "19.35.36" | ||
| private ANDROID_VERSION = "13" | ||
| private ANDROID_USER_AGENT = "com.google.android.youtube/#{ANDROID_APP_VERSION} (Linux; U; Android #{ANDROID_VERSION}; en_US; SM-S908E Build/TP1A.220624.014) gzip" | ||
| private ANDROID_SDK_VERSION = 33_i64 |
There was a problem hiding this comment.
(Just a comment not a blocking code review) Wait why was ANDROID_SDK_VERSION even originally a 64 bit integer instead of Crystal's default 32 bit integer? I mean it doesn't really matter but its odd that this one constant was singled out to become a 64 bit integer especially when the value shouldn't ever even come close to the signed 32 bit integer limit...
Co-authored-by: syeopite <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Updates the versions of some clients and fixes #5324
What has been tested:
inv_sig_helper, videoplayback works fine on DASH and MediumEverything seems to work fine on my end so I doubt this is going to break something.
Versions were taken from https://github.com/LuanRT/YouTube.js/blob/0f1fd7223c2e5c8e28637e84a1c00c6d88fad50f/src/utils/Constants.ts#L59