Remove trending page from Invidious #5537
Conversation
| <% | ||
| # Remove the Trending page from the menu for users with the Trending | ||
| # item inside their PREFS cookie or in their user preferences saved | ||
| # in the database (if registered user) | ||
| # https://github.com/iv-org/invidious/issues/5397 | ||
| %> | ||
| <% feed_menu.reject! {|item| "Trending" == item} %> |
There was a problem hiding this comment.
I'm not sure if this is a good way to remove the Trending page from the feed menu. Registered users and unregistered users with the PREFS cookie set with Trending inside their feed_menu preferences will get the Trending option in their Feed menu, but since Trending is removed, is going to be a dead option that does nothing. So I did this to basically strip Trending from the feed menu if it's available on the user preferences.
Registered users and unregistered users will have to save their preferences again in order to remove Trending from their feed_menu preferences.
|
Newpipe can still show a trending page, it's by default the livestream trending page. Maybe we could introduce the same thing? Allow the ability to select which trending tab the user wants. |
Yes is possible, Livestream trending page is the only one that works of all trending pages. For music, we should use https://charts.youtube.com/ instead. That is what NewPipe uses. And gaming can be fixed: https://www.youtube.com/gaming/trending So you are fine with just leaving the Livestream page in trending for now? |
|
Don't forget the Trending Trailers chart please. It's by country now though… |
| property quality_dash : String = "auto" | ||
| property default_home : String? = "Popular" | ||
| property feed_menu : Array(String) = ["Popular", "Trending", "Subscriptions", "Playlists"] | ||
| property feed_menu : Array(String) = ["Popular", "Subscriptions", "Playlists"] |
There was a problem hiding this comment.
Do you think that we should log a warning if feed_menu contains Trending in the server config?
| <meta name="description" content="<%= translate(locale, "An alternative front-end to YouTube") %>"> | ||
| <title> | ||
| <% if env.get("preferences").as(Preferences).default_home != "Trending" %> | ||
| <%= translate(locale, "Trending") %> - Invidious |
There was a problem hiding this comment.
Please remove "Trending" from the locales/en_US.json file, as well as other related translation string (there are more below). Weblate will take care of the other languages.
4 participants
Closes #5397
This completely strips the Trending page from Invidious since it's not available on Youtube anymore. Is not worth trying to find workarounds to keep the Trending page working as it will eventually break later.