Skip to content

Allow downloading via companion#5561

Merged
unixfox merged 4 commits intoiv-org:masterfrom
JeroenBoersma:master
Dec 19, 2025
Merged

Allow downloading via companion#5561
unixfox merged 4 commits intoiv-org:masterfrom
JeroenBoersma:master

Conversation

@JeroenBoersma
Copy link
Copy Markdown
Contributor

post request where not proxied to the companion

This made it impossible to download with the companion enabled

* post request where not proxied for the download companion which made
  it impossible to download with the companion enabled
@unixfox
Copy link
Copy Markdown
Member

unixfox commented Dec 12, 2025

You mean when using the download feature in the invidious frontend?

Because that should work as implemented in #5224

@JeroenBoersma
Copy link
Copy Markdown
Contributor Author

You mean when using the download feature in the invidious frontend?
Yes, the frontend route is indeed changed, but it is a post request to /companion/download?... and the post data isn't proxied to the companion so a redirect to the / occurs.

This fix implements a POST forward to the companion.

Screenshot_2025-12-13_10-28-12

Copy link
Copy Markdown
Member

@Fijxu Fijxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, good catch!

@unixfox Download didn't work when Invidious companion was being proxied due to that missing route

@unixfox unixfox merged commit dbbaf51 into iv-org:master Dec 19, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants