Remove redundant buildscript force block (revert #34)#37
Merged
Conversation
The alerts #34 targeted were all build-time AGP tooling transitives that never ship. They are now resolved at the source by scoping the dependency submission to the published runtime classpaths (#36) — the Dependabot dashboard shows 0 open alerts. With the buildscript classpath no longer in the submitted graph, this force block silences nothing. Keeping it only risks silently downgrading/conflicting with AGP's bundled tooling on a future AGP upgrade (already seen with commons-io 2.15.1 -> 2.14.0). ./gradlew build stays green without it. This reverts commit c729827.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
KotlinTextMate Benchmark
Details
| Benchmark suite | Current: 8008c85 | Previous: 7cd6ed9 | Ratio |
|---|---|---|---|
dev.textmate.benchmark.TokenizerBenchmark.tokenizeFile ( {"grammar":"kotlin"} ) |
32.69804782795699 ms/op |
31.824729118055558 ms/op |
1.03 |
dev.textmate.benchmark.TokenizerBenchmark.tokenizeFile ( {"grammar":"json"} ) |
11.802254278431372 ms/op |
13.212511730263156 ms/op |
0.89 |
dev.textmate.benchmark.TokenizerBenchmark.tokenizeFile ( {"grammar":"markdown"} ) |
446.4566271111111 ms/op |
411.82717652 ms/op |
1.08 |
dev.textmate.benchmark.TokenizerBenchmark.tokenizeFile ( {"grammar":"javascript"} ) |
1718.1481666666668 ms/op |
1515.6506855999999 ms/op |
1.13 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The 27+ Dependabot alerts that #34 forced patched versions for were all build-time AGP/lint tooling transitives that never ship in the published
:core/:compose-uiartifacts. They're now resolved at the source by #36, which scopes the dependency submission to the published runtime classpaths — the Dependabot dashboard is at 0 open alerts.With the buildscript classpath no longer part of the submitted graph, the
buildscript { … force(…) }block from #34 silences nothing. Keeping it only adds risk: on a future AGP upgrade a pin can silently downgrade/conflict with AGP's bundled tooling (already observed withcommons-io2.15.1 → 2.14.0).Change
Reverts the force block (
c729827).build.gradle.ktsreturns to imports →plugins, 31 lines removed.Verification
./gradlew build— green without the block.Reverts c729827.