Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ client = ClientBuilder(endpoint="https://api.example.com"
,connection_timeout=10
,headers=headers
,retries=5
,delay=10)
,initial_delay=10)


### timeout, retry_strategy and headers are opcionals parameters
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "api-to-dataframe"
version = "1.2.1"
version = "1.2.2"
description = "A package to convert API responses to pandas dataframe"
authors = ["IvanildoBarauna <[email protected]>"]
readme = "README.md"
Expand Down
9 changes: 4 additions & 5 deletions src/api_to_dataframe/controller/client_builder.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from api_to_dataframe.models.retainer import RetryStrategies
from api_to_dataframe.models.retainer import Strategies
from api_to_dataframe.models.retainer import RetryStrategies, Strategies
from api_to_dataframe.models.get_data import GetData


Expand All @@ -9,7 +8,7 @@ def __init__(self,
headers: dict = None,
retry_strategy: Strategies = Strategies.NoRetryStrategy,
retries: int = 3,
delay: int = 1,
initial_delay: int = 1,
connection_timeout: int = 1):

"""
Expand All @@ -36,7 +35,7 @@ def __init__(self,
raise ValueError("::: endpoint param is mandatory :::")
if not isinstance(retries, int) or retries < 0:
raise ValueError("retries must be a non-negative integer")
if not isinstance(delay, int) or delay < 0:
if not isinstance(initial_delay, int) or initial_delay < 0:
raise ValueError("delay must be a non-negative integer")
if not isinstance(connection_timeout, int) or connection_timeout < 0:
raise ValueError("connection_timeout must be a non-negative integer")
Expand All @@ -46,7 +45,7 @@ def __init__(self,
self.connection_timeout = connection_timeout
self.headers = headers
self.retries = retries
self.delay = delay
self.delay = initial_delay

@RetryStrategies
def get_api_data(self):
Expand Down
4 changes: 2 additions & 2 deletions tests/test_controller_client_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def test_constructor_raises():
with pytest.raises(ValueError):
new_client = ClientBuilder(
endpoint="https://economia.awesomeapi.com.br/last/USD-BRL",
delay=-1
initial_delay=-1
)

with pytest.raises(ValueError):
Expand All @@ -48,7 +48,7 @@ def test_constructor_raises():
with pytest.raises(ValueError):
new_client = ClientBuilder(
endpoint="https://economia.awesomeapi.com.br/last/USD-BRL",
delay=""
initial_delay=""
)

with pytest.raises(ValueError):
Expand Down
4 changes: 2 additions & 2 deletions tests/test_models_retainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def test_linear_strategy():
endpoint=endpoint,
retry_strategy=RetryStrategies.LinearRetryStrategy,
retries=max_retries,
delay=1,
initial_delay=1,
connection_timeout=1
)

Expand Down Expand Up @@ -47,7 +47,7 @@ def test_exponential_strategy():
endpoint=endpoint,
retry_strategy=RetryStrategies.ExponentialRetryStrategy,
retries=max_retries,
delay=1,
initial_delay=1,
connection_timeout=1
)

Expand Down