Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate returns all errors #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Validate returns all errors #1

wants to merge 1 commit into from

Conversation

ivawzh
Copy link
Owner

@ivawzh ivawzh commented Jul 31, 2020 •
edited
Loading

TODO:

  1. discuss breaking changes to Failure
  2. since there will be breaking changes, can we also make check and validate async? I want to be able to use withConstraint with network call and thus promises.
  3. finish the validator changes

Currently

  1. typecheck failing with 33 errors
  2. tests failing with 429 units

@ivawzh ivawzh mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivawzh