Skip to content

Bidimensional ruler tool#2084

Merged
ivmartel merged 8 commits intoivmartel:developfrom
SreejaReghu:bidimensional_tool
Feb 18, 2026
Merged

Bidimensional ruler tool#2084
ivmartel merged 8 commits intoivmartel:developfrom
SreejaReghu:bidimensional_tool

Conversation

@SreejaReghu
Copy link
Contributor

@SreejaReghu SreejaReghu commented Feb 13, 2026

This PR includs the implementation of the bidimensional tool in the DWV application

@SreejaReghu SreejaReghu changed the title DV-2160 : Perpendicular axis measurment in RECIST DV-2160 : Perpendicular axis tool Feb 13, 2026
@ivmartel
Copy link
Owner

Could you add a test in the tests/annotation folder to check the import/export?

@ivmartel
Copy link
Owner

Regarding the code, you added bidimensional logic to the annotation and drawLayer files, I would prefer to keep these files as agnostic as possible to shape specifics, could you move that logic to the math shape?

@ivmartel
Copy link
Owner

Regarding the bidimensional tool, the 'hit' zone, the zone where a click selects the shape, is a bit small. Could you check the ruler tool to see how this zone can be made bigger (search for hitFunc)?

@SreejaReghu
Copy link
Contributor Author

The review comments have been updated. Could you please check?

@ivmartel ivmartel changed the title DV-2160 : Perpendicular axis tool Bidimensional ruler tool Feb 17, 2026
@SreejaReghu
Copy link
Contributor Author

The review comment have been updated. Could you please check?

@ivmartel ivmartel dismissed their stale review February 18, 2026 08:59

All changes accepted

@ivmartel ivmartel added the enhancement New feature or request label Feb 18, 2026
@ivmartel ivmartel added this to the 0.37.0 milestone Feb 18, 2026
@ivmartel ivmartel merged commit 96be9fc into ivmartel:develop Feb 18, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants