Adding "generated" to the list of accepted param flags.#17
Open
Adding "generated" to the list of accepted param flags.#17
Conversation
Collaborator
Author
|
Oh, this is trying to address ivoa-std/TAP#11, too. |
Member
msdemlei
force-pushed
the
add-dynamic-content-flag
branch
from
a7521ba to
b8d9acf
Compare
Also, opening the PR cycle.
msdemlei
force-pushed
the
add-dynamic-content-flag
branch
from
b8d9acf to
323d3e0
Compare
Collaborator
Author
|
On Wed, Apr 15, 2026 at 09:19:13AM -0700, Mark Taylor wrote:
mbtaylor left a comment (ivoa-std/VODataService#17)
@msdemlei, since PR #16, now approved, has a load of whitespace
noise in the .tex file too, presumably the same changes, how about
merging that first and then rebasing this on top of it?
Ah. Thanks. Yes, that fixed it.
|
Member
|
Content of the PR looks OK, but I haven't approved so far since it's not clear that discussions on the DAL list about nomenclature of the proposed new flag have reached conclusion. |
mbtaylor
approved these changes
Apr 27, 2026
Member
mbtaylor
left a comment
mbtaylor
left a comment
There was a problem hiding this comment.
I'll give it an approval, on the grounds that the commit looks OK. But given the fact that there has been not-obviously-unanimous discussion on nomenclature, I'd give it a week or two in case anybody dislikes no-where enough to argue further here or on-list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, opening the PR cycle.
Sorry about the ivoatex-related whitespace changes that are in here. Can you pretend they are not there? The real change to review is in the XSD, everything else is just noise.