fix: wrap go interface returns as option#458
Merged
Merged
Conversation
Merged
Contributor
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go functions and methods returning an interface now correctly bind as
Option<T>, reflecting the fact that any Go interface value can benil. Previously Lisette claimed the result was always present, so a caller could deref into a runtime panic with no protection from the type checker.The same change applies to function returns where the body has a
return nilpath, such ascontainer/ring.New(0)andmath/big.Int.ModInverse.For well-known constructors that never return
nilin practice but whose multi-path bodies cannot be statically narrowed, explicit allowlist entries inbindgen.stdlib.jsonkeep the original non-Option binding.Close #438