Skip to content

fix: correct Redis environment variable name inconsistency in api/.env.sample#83

Merged
jurajhilje merged 1 commit intoivpn:mainfrom
lamtrinhdev:Update_.env.sample
Apr 17, 2026
Merged

fix: correct Redis environment variable name inconsistency in api/.env.sample#83
jurajhilje merged 1 commit intoivpn:mainfrom
lamtrinhdev:Update_.env.sample

Conversation

@lamtrinhdev
Copy link
Copy Markdown
Contributor

PR type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other... Please describe:

Sample environment configuration.

PR checklist

Please check if your PR fulfills the following requirements:

  • I have read the CONTRIBUTING.md doc
  • The Git workflow follows our guidelines: CONTRIBUTING.md#git
  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

What is the current behavior?

Issue number: N/A

The code in config/config.go:150 uses REDIS_ADDRESSES as the environment variable name, but the .env.sample file defines REDIS_ADDRS. This inconsistency causes the Redis configuration to fail when using .env.sample (the environment variable is never read correctly.).

What is the new behavior?

Changed REDIS_ADDRS to REDIS_ADDRESSES in .env.sample to match the environment variable defined in config/config.go.

Does this PR introduce a breaking change?

  • Yes
  • No

@lamtrinhdev
Copy link
Copy Markdown
Contributor Author

Dear @jurajhilje ,

I just update a small thing. When you have time, please help me to review it.

Thanks,
Lam

@jurajhilje jurajhilje self-requested a review April 16, 2026 16:37
@jurajhilje jurajhilje self-assigned this Apr 16, 2026
@jurajhilje jurajhilje added the API label Apr 16, 2026
@jurajhilje jurajhilje merged commit 25d56e6 into ivpn:main Apr 17, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants