Skip to content

feat(android):Target SDK 35 Compatibility (Edge to Edge enforcement) Ucrop Activity #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dishantwalia
Copy link
Contributor

After upgrading to target SDK 35, we observed an impact on Android 15 devices, as apps are now edge-to-edge by default if they target Android 15 (API level 35). Image crop picker also impacted with this change as Ucrop activity tool bar distorted and displayed in place of the device status bar and hence user is unable to tap on the icons. Hence removing the style from activity.
Impacted Device : Android 15 & Android 16 with target SDK 35

Before :
787cefbf-b1e1-42c7-9e77-380f8935a8f3

After:
Screenshot_20250527_152608

After upgrading to target SDK 35, we observed an impact on Android 15 devices, as apps are now edge-to-edge by default if they target Android 15 (API level 35). Image crop picker also impacted with this change as Ucrop activity tool bar distorted and displayed in place of the device status bar and hence user is unable to tap on the icons.
Hence removing the style from activity
@dishantwalia dishantwalia changed the title feat(android):Target SDK 35 Compatibility (Edge to Edge enforcement) feat(android):Target SDK 35 Compatibility (Edge to Edge enforcement) Ucrop Activity May 27, 2025
@kontea-dev
Copy link

kontea-dev commented Jun 4, 2025

Hello @dishantwalia @ivpusic , do you know when this PR will be merged ? :)
PS : i've test this fix but seems still not working, but this oner looks good :) #2168

@dishantwalia
Copy link
Contributor Author

dishantwalia commented Jun 6, 2025

Hello @dishantwalia @ivpusic , do you know when this PR will be merged ? :) PS : i've test this fix but seems still not working, but this oner looks good :) #2168

Do you have an action bar defined in your root project Mainactivity styles? Can you share the parent style?

The intention behind removing the style from UCropActivity is to allow it to inherit from the root style, which aligns better with the app's global theming.
** but this will not work if you have defined action bar on parent style **

That said, Solution 2 also looks reasonable, but it introduces a risk of future maintenance overhead especially if there are changes in attributes or style definitions that could break compatibility. However let the maintainer decide if they agree with option 2 then we can use that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants