fix: comment out local 'from import' transformation assertions that are raising with our new transpiler testing structure#28853
Merged
Sam-Armstrong merged 1 commit intomainfrom Jan 17, 2025
Conversation
…re raising with our new transpiler testing structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@YushaArif99 the transformations tests that I've commented out here have started failing after migrating them over to the ivy repository.
Of course the prefix of the calls in these assertions should now be something like
ivy_tests.test_transpiler.transformations.mock_dir.custom_math.advanced_mathrather thantests.source2source.transformations.mock_dir.custom_math.advanced_math, but for some reason there is no prefix at all when it asserts, at least on the first example here. Would you be able to have a look into this at some point if you get chance?This doesn't seem to have any downstream consequences on the integration tests and such - so I presume it's an issue with the way the testing/file structure is now set up in ivy - given this I'll just leave these parts commented out for the moment until we have chance to look into it.
Cheers!