Conversation
|
@Sam-Armstrong @YushaArif99 Good Afternoon. Would like to request for a review? |
Sam-Armstrong
left a comment
There was a problem hiding this comment.
@yugborana Thanks for making the PR!
Looks like there's a few more things that will need changing before this works correctly. For example, you'll need to add torch as one of the SUPPORTED_S2S_TARGETS in ivy/transpiler/main_config.py.
I'd recommend using the following minimal example to check your solution is working correctly:
import kornia
import torch
import ivy
new_kornia = ivy.transpile(kornia, target="torch", reuse_existing=False)
rgb_image = torch.randn((1, 3, 224, 224))
gray_image = new_kornia.color.rgb_to_grayscale(rgb_image)
You can see this currently fails with the error ivy.transpiler.exceptions.exceptions.InvalidTargetException: 'target' must be one of ['tensorflow', 'jax', 'numpy', 'ivy', 'torch_frontend']. - but it looks like there are still other problems after fixing this.
|
@Sam-Armstrong Thanks for your time and guidance. I have changed the targets list. File "c:\Users\dell\ivy\test.py", line 7, in Yeah many errors occurring. |
|
@Sam-Armstrong these are the errors, could you please guide more, where should I do changes? |
|
@yugborana Can you push that change to the targets list? For this fix, it looks like you'll need to add another elif block in |
|
@Sam-Armstrong I have pushed the changes. But now, I think we have to do something with torch stateful layers? |
PR Description
Related Issue
#28848
Checklist