Skip to content

Fix Ivy Failing Test: jax - random.multinomial #28913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sam-Armstrong merged 2 commits into from
Jul 21, 2025
Merged

Fix Ivy Failing Test: jax - random.multinomial #28913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e03de1c
random.multinomial tests
Ajay6601 Jul 19, 2025
2b33ef8
fix: remove unnecessary files
Sam-Armstrong Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ivy_tests/test_ivy/test_functional/test_core/test_random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ def call():
replace=replace,
seed=seed,
)

ret = call()

if not ivy.exists(ret):
Expand All @@ -100,16 +99,25 @@ def call():
ret_np, ret_from_np = ret
if seed:
ret_np1, ret_from_np1 = call()

assert ivy.any(ret_np == ret_np1)

flat_ret_np = helpers.flatten_and_to_np(ret=ret_np, backend=backend_fw)
flat_ret_np1 = helpers.flatten_and_to_np(ret=ret_np1, backend=backend_fw)

found_equal = False
for arr1, arr2 in zip(flat_ret_np, flat_ret_np1):
if ivy.any(ivy.array(arr1 == arr2)):
found_equal = True
break

assert found_equal

ret_np = helpers.flatten_and_to_np(ret=ret_np, backend=backend_fw)
ret_from_np = helpers.flatten_and_to_np(
ret=ret_from_np, backend=test_flags.ground_truth_backend
)
for u, v in zip(ret_np, ret_from_np):
assert u.dtype == v.dtype
assert u.shape == v.shape
assert 'int' in str(u.dtype) and 'int' in str(v.dtype)
assert u.size == v.size


# randint
Expand Down
Loading