Avoid race-condition when scheduling throttled jobs #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 98.30% 98.31%
=======================================
Files 19 19
Lines 473 474 +1
Branches 79 80 +1
=======================================
+ Hits 465 466 +1
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pezra
force-pushed
the
schedule-retry-race-cond
branch
from
4f40ee6 to
efdad7c
Compare
install_if does all of the bundling work even if the condition is false. That means it fetches the packages list from gems.contribsys.com before it even checks the condition. If BUNDLE_GEMS__CONTRIBSYS__COM isn't set it that fetch fails with an auth error.
When a job was throttled and the queue of pending jobs was fully drained between the throttle? decision and the delay calculation, the retry code would fail with "NoMethodError undefined method `last' for nil:NilClass"
pezra
force-pushed
the
schedule-retry-race-cond
branch
from
efdad7c to
41ee01c
Compare
|
Sorry took a while to get to this. Thanks for the fix. |
ixti
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a job was throttled and the queue of pending jobs was fully drained between the throttle? decision and the delay calculation, the retry code would fail with "NoMethodError undefined method `last' for nil:NilClass". I don't see a way to write a test for this since it is very timing based and highly intermittent.
fixes #206
PS: I changed the appraisals file because install_if does all of the bundling work regardless of whether the condition evaluates to true or false. In fact, it fetches the packages list from gems.contribsys.com before it even checks the condition. If BUNDLE_GEMS__CONTRIBSYS__COM isn't set that fetch fails with an auth error.