backlog size aware throttling #209
Open
+237
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install_if does all of the bundling work even if the condition is false. That means it fetches the packages list from gems.contribsys.com before it even checks the condition. If BUNDLE_GEMS__CONTRIBSYS__COM isn't set it that fetch fails with an auth error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 98.30% 98.38% +0.07%
==========================================
Files 19 19
Lines 473 494 +21
Branches 79 86 +7
==========================================
+ Hits 465 486 +21
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This avoids unnecessary processing delays and smoothes the load on sidekiq workers.
pezra
force-pushed
the
queue-depth-aware-throttling
branch
from
880a11e to
df35ceb
Compare
|
@ixti any chance we could get this into a release sometime soon? My team as been using is for a while now, and it solves some serious operational issues we were experiencing. I'm sure other would benefit from it too. |
|
Sorry, missed this one. Will handle the PR this week. |
|
@ixti bump 😄 |
ixti
reviewed
Jun 9, 2025
| old_size = (old_size_str || 0).to_f | ||
| old_timestamp = (old_timestamp_str || Time.now).to_f | ||
|
|
||
| nonneg(old_size - jobs_lost_since(old_timestamp, job_args)) |
There was a problem hiding this comment.
IMO it's better to use clamp than add new method:
Suggested change
| nonneg(old_size - jobs_lost_since(old_timestamp, job_args)) | |
| (old_size - jobs_lost_since(old_timestamp, job_args)).clamp(0, nil) |
|
|
||
| Sidekiq.redis { |redis| 1 == SCRIPT.call(redis, keys: keys, argv: argv) } | ||
| Sidekiq.redis { |redis| (1 == SCRIPT.call(redis, keys: keys, argv: argv)) } |
There was a problem hiding this comment.
Parenthesis are redundant here
Suggested change
| Sidekiq.redis { |redis| (1 == SCRIPT.call(redis, keys: keys, argv: argv)) } | |
| Sidekiq.redis { |redis| 1 == SCRIPT.call(redis, keys: keys, argv: argv) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
retry_incalculation for concurrency throttled jobs using the:schedulestrategy. The approach is to estimate when a throttled job will likely be runnable and schedule it for that time. This estimate is based on the current backlog size for the job group (estimated), the expected job runtime and the concurrency limit.This should reduce/eliminate unnecessary delays in job processing caused by the current "ignore throttled jobs for TTL seconds" approach while retaining the benefits of the schedule strategy.
PS: I changed the appraisals file because install_if does all of the bundling work regardless of whether the condition evaluates to true or false. In fact, it fetches the packages list from gems.contribsys.com before it even checks the condition. If BUNDLE_GEMS__CONTRIBSYS__COM isn't set that fetch failed with an auth error.