Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sidekiq::Web.configure for Web UI #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hiemanshu
Copy link

This fixes #207, Sidekiq::Web.register is deprecated, and Sidekiq 8 requires .configure to be used.

It also happens to be a nicer API than what currently exists.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.30%. Comparing base (11aefdf) to head (06d759d).

Files with missing lines Patch % Lines
lib/sidekiq/throttled/web.rb 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   98.71%   98.30%   -0.41%     
==========================================
  Files          19       19              
  Lines         468      473       +5     
  Branches       77       79       +2     
==========================================
+ Hits          462      465       +3     
- Misses          6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeffbax
Copy link

jeffbax commented Apr 2, 2025

Thank you for doing this PR, would love to see it get merged @ixti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidekiq 8 Support
2 participants