feat(component): feat(webhook): Adds support for interactive nfm_reply payloads (WhatsApp Flows) in the webhook parser and improves signature hashing - #6
Conversation
Summary of ChangesHello @RyzorBent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates support for WhatsApp Flows' interactive Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for interactive nfm_reply payloads from WhatsApp Flows and enhances the security of webhook signature verification. While the signature hashing is made more robust by normalizing the request buffer, the signature verification logic remains vulnerable to a timing attack due to the use of a standard string comparison for the HMAC hash. It is recommended to remediate this by using a constant-time comparison function like crypto.timingSafeEqual. Additionally, a small refactoring in the webhook handler could simplify the logic for processing interactive messages, improving code clarity and maintainability.
|
This PR addresses -> #4 |
Description of change
Adds support for interactive
nfm_replypayloads (WhatsApp Flows) in the webhook parser and improves signature hashing by normalizing the request buffer before computing the HMAC. This keeps interactive replies consistent across types and avoids signature verification issues in environments where the raw body is a Buffer-like object.Verification:
Pull-Request Checklist
mainbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000(N/A)https://www.conventionalcommits.org/en/v1.0.0/