Skip to content

feat(component): feat(webhook): Adds support for interactive nfm_reply payloads (WhatsApp Flows) in the webhook parser and improves signature hashing - #6

Open
RyzorBent wants to merge 4 commits into
j05u3:mainfrom
RyzorBent:main
Open

feat(component): feat(webhook): Adds support for interactive nfm_reply payloads (WhatsApp Flows) in the webhook parser and improves signature hashing#6
RyzorBent wants to merge 4 commits into
j05u3:mainfrom
RyzorBent:main

Conversation

@RyzorBent

@RyzorBent RyzorBent commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Description of change

Adds support for interactive nfm_reply payloads (WhatsApp Flows) in the webhook parser and improves signature hashing by normalizing the request buffer before computing the HMAC. This keeps interactive replies consistent across types and avoids signature verification issues in environments where the raw body is a Buffer-like object.

Verification:

  • Not run locally (not requested)

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000 (N/A)
  • There are new or updated unit tests validating the change (N/A)
  • Documentation has been updated to reflect this change (N/A)
  • The new commits follow conventions outlined in the https://www.conventionalcommits.org/en/v1.0.0/

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @RyzorBent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates support for WhatsApp Flows' interactive nfm_reply messages into the webhook parser, allowing the system to properly interpret and process these new types of interactive responses. Concurrently, it refines the webhook signature hashing mechanism to ensure robustness and prevent verification failures that could arise from inconsistencies in request body handling across various Node.js environments.

Highlights

  • WhatsApp Flows (nfm_reply) Support: The webhook parser now correctly handles interactive nfm_reply payloads, which are part of WhatsApp Flows, allowing the system to process these new interactive responses.
  • Enhanced Signature Hashing: The webhook signature verification process has been improved by normalizing the request body to a Uint8Array before HMAC computation, ensuring consistent and reliable signature validation across different environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for interactive nfm_reply payloads from WhatsApp Flows and enhances the security of webhook signature verification. While the signature hashing is made more robust by normalizing the request buffer, the signature verification logic remains vulnerable to a timing attack due to the use of a standard string comparison for the HMAC hash. It is recommended to remediate this by using a constant-time comparison function like crypto.timingSafeEqual. Additionally, a small refactoring in the webhook handler could simplify the logic for processing interactive messages, improving code clarity and maintainability.

Comment thread src/expressRouter.ts
Comment thread src/expressRouter.ts
@RyzorBent

Copy link
Copy Markdown
Contributor Author

This PR addresses -> #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant