Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stk 3020 upgrade haystack 4 #21

Merged
merged 13 commits into from
Jan 6, 2025

Conversation

garethj2
Copy link
Contributor

@garethj2 garethj2 commented Jan 3, 2025

A long overdue upgrade of haystack core to make it up to date with the latest haystack standard.

Please see these proposals that have now been implemented (except https://project-haystack.org/forum/topic/937)...

This proposal has these sub-proposals that have now been implemented...

935: simplify how choices work for the common case to so that they work like all other tags
936: redesign how choices work for the complicated specialization use case via a new design pattern using the of tag
938: finalize the question mark inference operator in filter syntax
939: remove the equipFunction taxonomy until we learn more

Please note this proposal has not been implemented as the changes haven't yet made it into the main haystack-defs repo...

937: redesign ref of (domain/referent of the relationship) to use filters and eliminate the fluid-xxx def explosion

Overall the main biggest changes are...

  • Reworked choices (minor).
  • Refactor how defs are used in the automated tests.
  • Reworked relationship haystack filter query.
  • Using latest version of Rust with all clippy recommendations implemented. @hecsalazarf please take a look at these changes. It's been a while since I've coded in Rust and I've lost a little confidence when it comes to use of life times.
  • Detect haystack filter parser fragments. It seems like not all of a filter was being parsed properly and some error cases where being missed.

Please note, when we release this change, I'll make it a new major version since it relies on a newer version of haystack defs.

@garethj2 garethj2 self-assigned this Jan 3, 2025
src/haystack/defs/namespace.rs Outdated Show resolved Hide resolved
src/haystack/defs/namespace.rs Outdated Show resolved Hide resolved
src/haystack/defs/namespace.rs Outdated Show resolved Hide resolved
src/haystack/filter/parser.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@rracariu rracariu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hector's comments look sensible too.
It might require a cargo update to get all the deps to latest.

@garethj2 garethj2 merged commit 5f9a08a into master Jan 6, 2025
12 checks passed
@garethj2 garethj2 deleted the feature/STK-3020-upgrade-haystack-4 branch January 6, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants