-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/stk 3020 upgrade haystack 4 #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecsalazarf
approved these changes
Jan 3, 2025
rracariu
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Hector's comments look sensible too.
It might require a cargo update
to get all the deps to latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long overdue upgrade of haystack core to make it up to date with the latest haystack standard.
Please see these proposals that have now been implemented (except https://project-haystack.org/forum/topic/937)...
This proposal has these sub-proposals that have now been implemented...
935: simplify how choices work for the common case to so that they work like all other tags
936: redesign how choices work for the complicated specialization use case via a new design pattern using the of tag
938: finalize the question mark inference operator in filter syntax
939: remove the equipFunction taxonomy until we learn more
Please note this proposal has not been implemented as the changes haven't yet made it into the main haystack-defs repo...
937: redesign ref of (domain/referent of the relationship) to use filters and eliminate the fluid-xxx def explosion
Overall the main biggest changes are...
Please note, when we release this change, I'll make it a new major version since it relies on a newer version of haystack defs.