Conversation
- The isaac sim compatibility checker already exists in the binary install (updated docs) - The cache path is different with Isaac Sim 5.0.0
WalkthroughThis PR systematically updates the Isaac Sim version from 5.0.0 to 5.1.0 across the entire project. Changes include updating version arguments in Dockerfiles, restructuring Docker Compose cache directory layouts, modifying the installation script, and updating documentation and URLs to reflect the new version. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
template_ws/docker/compose.yaml (1)
133-164: Consider keeping the template’s shared cache mount Isaac-Sim-specific.Line 137 now mounts the entire
/home/user/.cachetree intoisaac-sim-cache, so unrelated tool caches will persist and be shared here too. Since this is the template, that broader behavior will also be copied into future workspaces. If only Isaac Sim state needs persistence, narrow this back to the required subdirectories or add a short note that the wider sharing is intentional.ur5_ws/docker/compose.yaml (1)
117-123: Stale TODO comment is now misleading.The TODO on line 122 says "Uncomment the line below and comment out the three entries above to enable USB support", but the current state is already the inverse (individual devices commented,
/dev:/devenabled). This creates confusion about the intended default configuration.Consider updating or removing this TODO to reflect the new default state.
✏️ Suggested comment update
# Mount shared memory for ROS2 communication. # - /dev/shm:/dev/shm - # TODO: Uncomment the line below and comment out the three entries above to enable USB support. + # NOTE: Mounting /dev:/dev provides broader device access (USB, DRI, sound, etc.). + # For more restrictive access, comment out the line below and uncomment individual device mounts above. - /dev:/dev🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ur5_ws/docker/compose.yaml` around lines 117 - 123, Update the stale TODO that instructs to "Uncomment the line below and comment out the three entries above" to reflect the current state where the individual device mounts (# - /dev/dri:/dev/dri, # - /dev/snd:/dev/snd, # - /dev/shm:/dev/shm) are commented and the consolidated device mount "- /dev:/dev" is enabled; either remove the TODO or replace it with a clear note stating that USB/device support is currently enabled via "- /dev:/dev" and documenting when to prefer the individual mounts vs the consolidated mount.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/docker_run_official_isaac_sim.sh`:
- Line 31: The volume mount uses an unquoted $(pwd) which will undergo word
splitting if the current directory contains spaces; update the docker run
argument in scripts/docker_run_official_isaac_sim.sh to quote the expansion
(e.g., use "$(pwd)" or "$PWD") for the -v mount so the entire path is passed as
a single argument; change the occurrence of -v $(pwd):/home/ros2-essentials \ to
use a quoted expansion for robust mounts.
---
Nitpick comments:
In `@ur5_ws/docker/compose.yaml`:
- Around line 117-123: Update the stale TODO that instructs to "Uncomment the
line below and comment out the three entries above" to reflect the current state
where the individual device mounts (# - /dev/dri:/dev/dri, # -
/dev/snd:/dev/snd, # - /dev/shm:/dev/shm) are commented and the consolidated
device mount "- /dev:/dev" is enabled; either remove the TODO or replace it with
a clear note stating that USB/device support is currently enabled via "-
/dev:/dev" and documenting when to prefer the individual mounts vs the
consolidated mount.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c093575d-8149-4f85-a41f-39538364e6f9
📒 Files selected for processing (33)
CLAUDE.mdREADME.mdaloha_ws/docker/Dockerfilealoha_ws/docker/compose.yamldelto_gripper_ws/docker/Dockerfiledelto_gripper_ws/docker/compose.yamldocker_modules/install_isaac_sim.shdocs/docker-modules/isaac-sim.mdgazebo_world_ws/docker/Dockerfilegazebo_world_ws/docker/compose.yamlgo2_ws/docker/Dockerfilego2_ws/docker/compose.yamlh1_ws/docker/Dockerfileh1_ws/docker/compose.yamlhusky_ws/docker/Dockerfilehusky_ws/docker/compose.yamlkobuki_ws/docker/Dockerfilekobuki_ws/docker/compose.yamlorbslam3_ws/docker/Dockerfileorbslam3_ws/docker/compose.yamlscripts/docker_run_official_isaac_sim.shstretch3_ws/docker/Dockerfilestretch3_ws/docker/compose.yamltemplate_ws/docker/Dockerfiletemplate_ws/docker/compose.yamltests/diff_base/docker/Dockerfiletests/diff_base/docker/compose.yamlturtlebot3_ws/docker/Dockerfileturtlebot3_ws/docker/compose.yamlur5_ws/docker/Dockerfileur5_ws/docker/compose.yamlvlp_ws/docker/Dockerfilevlp_ws/docker/compose.yaml
| -v ~/docker/isaac-sim/data:/isaac-sim/.local/share/ov/data:rw \ | ||
| -v ~/docker/isaac-sim/pkg:/isaac-sim/.local/share/ov/pkg:rw \ | ||
| -u 1234:1234 \ | ||
| -v $(pwd):/home/ros2-essentials \ |
There was a problem hiding this comment.
Quote $(pwd) to prevent word splitting.
If the current working directory contains spaces, word splitting will cause the mount to fail.
🛠️ Proposed fix
- -v $(pwd):/home/ros2-essentials \
+ -v "$(pwd)":/home/ros2-essentials \📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| -v $(pwd):/home/ros2-essentials \ | |
| -v "$(pwd)":/home/ros2-essentials \ |
🧰 Tools
🪛 Shellcheck (0.11.0)
[warning] 31-31: Quote this to prevent word splitting.
(SC2046)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@scripts/docker_run_official_isaac_sim.sh` at line 31, The volume mount uses
an unquoted $(pwd) which will undergo word splitting if the current directory
contains spaces; update the docker run argument in
scripts/docker_run_official_isaac_sim.sh to quote the expansion (e.g., use
"$(pwd)" or "$PWD") for the -v mount so the entire path is passed as a single
argument; change the occurrence of -v $(pwd):/home/ros2-essentials \ to use a
quoted expansion for robust mounts.
This was referenced Mar 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #98
Summary by CodeRabbit
Release Notes
Documentation
Chores