Conversation
✅ Deploy Preview for webcrack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for the PR This breaks compatibility with node 18.x and 20.x unfortunately (majority of users), I can merge after laverdet/isolated-vm#532 and/or laverdet/isolated-vm#534 is resolved |
|
I'm preparing a soft-fork at https://github.com/ItsHarper/webcrack / https://itsharper-webcrack.netlify.app/, which I'm only planning on keeping active until this PR (or perhaps the more complete ItsHarper@32d6157) gets commited to the upstream version. I'm also planning to update to the babel 8 beta (see my fork's readme). @j4k0xb Do you mind if I call it |
|
@ItsHarper sure you can do it if you want |
|
Node.js is practically begging people to upgrade to version 22 anyway: https://nodejs.org/en/blog/announcements/node-18-eol-support. I think there's value in helping nudge people in that direction. |
Context
This PR addresses #183 by bumping isolated-vm to 6.0.0
Tests via
pnpm testpass