Update OGGLoader.java #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Okay. Internal PRs are still a todo, because the branch creation commit is ignored and then submitting the PR causes no additional check_suite.requested event. |
on an existing branch-pr should cause the analyzer to run on this commit, now that it has a valid base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test for in-branch Pull Requests.
It turns out that committing/creating a new branch did trigger a check run with the
beforehash set to 0x0[....].That doesn't (yet) work with our differ, but let's see if opening a PR triggers this again, because then the individual commits get a reference.
I wonder however, if we should explicitly skip commits on different branches, because the differ will only look for individual commits on branches and as such ignore the first commit. This is then a question of trust for people with direct commit access.