fix: update Dutch book names for consistency and accuracy#56
Open
jaapkramer wants to merge 1 commit intojaanonim:masterfrom
Open
fix: update Dutch book names for consistency and accuracy#56jaapkramer wants to merge 1 commit intojaanonim:masterfrom
jaapkramer wants to merge 1 commit intojaanonim:masterfrom
Conversation
Owner
|
I think that it woudl be better to not remove any existing names, because sombody maybe used to them even if they are no 100% correct. |
Owner
|
@jaapkramer are you planning to address my comment or should i close this PR? |
Contributor
Author
|
My apologies, I only saw the notification that you closed the PR, I didn't saw your previous comment. I'll look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Dutch book name abbreviations in the
data/books/nl.jsonfile to better align with standard conventions and improve consistency. The primary changes involve refining abbreviations for several New Testament books.Abbreviation updates for New Testament books:
MRK: Changed alternate names from"marcus", "marc"to"markus", "mar"for improved consistency.1COand2CO: Removed"1cor"and"2cor", keeping only"1kor"and"2kor"as abbreviations.EPH: Added"efe"and kept"ef", updating the list to"efeziërs", "efz", "ef", "efe".COL: Removed"col", keeping only"kol"as the abbreviation.JAS: Removed"jac", keeping only"jak"as the abbreviation.