Conversation
Signed-off-by: Sophon96 <71684640+Sophon96@users.noreply.github.com>
Member
|
This looks great! |
| let addr = "0.0.0.0:5768".parse()?; | ||
| let cd_svc = client_server::ClientDaemonService {}; | ||
| let cd_srv = ClientDaemonServer::new(cd_svc); | ||
| println!("Client gRPC server on {}", addr); |
Member
There was a problem hiding this comment.
It looks like you implement the connection here, is it work?
Member
Author
There was a problem hiding this comment.
Yep! If you run it, you can use a gRPC client like BloomRPC and import proto/client_daemon.proto and fire off RPC calls, though all of them are just blank for now.
Member
Author
|
That was fast! Let me draft out a few tasks that need to be done before this can be merged... |
Member
|
Cool cool, great work! |
This reverts commit af1edae.
…am in daemon Signed-off-by: Sophon96 <71684640+Sophon96@users.noreply.github.com>
Signed-off-by: Sophon96 <71684640+Sophon96@users.noreply.github.com>
Signed-off-by: Sophon96 <71684640+Sophon96@users.noreply.github.com>
Signed-off-by: Sophon96 <71684640+Sophon96@users.noreply.github.com>
Sophon96
marked this pull request as ready for review
November 19, 2022 06:29
Sophon96
marked this pull request as draft
November 20, 2022 00:50
Camerooooon
approved these changes
Nov 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only aims to implement communication between the client and the daemon.
Proto
Daemon
Client