Skip to content

Fix livox_ros_driver2 Jazzy CMake generation#7

Merged
marc-hanheide merged 6 commits into
masterfrom
fix/jazzy_build
Jun 15, 2026
Merged

Fix livox_ros_driver2 Jazzy CMake generation#7
marc-hanheide merged 6 commits into
masterfrom
fix/jazzy_build

Conversation

@ibrahimhroob

Copy link
Copy Markdown
  • Fixes livox_ros_driver2 build failure on ROS 2 Jazzy caused by LIVOX_INTERFACES_INCLUDE_DIRECTORIES resolving to NOTFOUND.
  • Uses rosidl_get_typesupport_target() to resolve and link the generated custom message C++ typesupport target.
  • Removes direct use of generated interface include-directory properties, letting the typesupport target provide the needed include paths.
  • Sets CMake policy CMP0144 defaults to suppress the PCL/FLANN developer warning during configuration.

Validation:

  • Ran colcon build --packages-select livox_ros_driver2
  • Build completed successfully with no stderr output.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes ROS 2 Jazzy CMake generation/linking issues for the package’s generated custom messages by resolving and linking the correct C++ typesupport target (instead of reading INTERFACE_INCLUDE_DIRECTORIES, which can resolve to NOTFOUND on Jazzy), and suppresses a CMake developer warning via policy settings.

Changes:

  • Resolve the generated custom message C++ typesupport target via rosidl_get_typesupport_target() (with a fallback target name) and link it into livox_ros_driver2.
  • Remove direct reliance on the generated target’s INTERFACE_INCLUDE_DIRECTORIES, letting the typesupport target provide include paths transitively.
  • Set CMake policy CMP0144 to NEW (when available) to silence the PCL/FLANN developer warning during configure.

@marc-hanheide

Copy link
Copy Markdown
Member

@ibrahimhroob I added CI for jazzy to test this properly

@marc-hanheide

Copy link
Copy Markdown
Member

@ibrahimhroob

Copy link
Copy Markdown
Author

It did build fine on the navstack jazzy image, this is the sdk install in our base image: https://github.com/jabasai/navstack_container_base/blob/7d413a086660dc138a20a45afdcfd7d0bc25b5dd/docker/Dockerfile#L85-L93

@marc-hanheide

Copy link
Copy Markdown
Member

works now, I’ll merge.

@marc-hanheide
marc-hanheide merged commit 1b8f5cb into master Jun 15, 2026
2 of 4 checks passed
@marc-hanheide
marc-hanheide deleted the fix/jazzy_build branch June 15, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants