Skip to content

pgtype numeric optimization: replace Cmp(big0) with Sign() #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackc merged 1 commit into from
Nov 1, 2025
Merged

pgtype numeric optimization: replace Cmp(big0) with Sign() #2414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions pgtype/numeric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const (
)

var (
big0 *big.Int = big.NewInt(0)
big1 *big.Int = big.NewInt(1)
big10 *big.Int = big.NewInt(10)
big100 *big.Int = big.NewInt(100)
Expand Down Expand Up @@ -166,7 +165,7 @@ func (n *Numeric) toBigInt() (*big.Int, error) {
div.Exp(big10, big.NewInt(int64(-n.Exp)), nil)
remainder := &big.Int{}
num.DivMod(num, div, remainder)
if remainder.Cmp(big0) != 0 {
if remainder.Sign() != 0 {
return nil, fmt.Errorf("cannot convert %v to integer", n)
}
return num, nil
Expand Down Expand Up @@ -409,7 +408,7 @@ func encodeNumericBinary(n Numeric, buf []byte) (newBuf []byte, err error) {
}

var sign int16
if n.Int.Cmp(big0) < 0 {
if n.Int.Sign() < 0 {
sign = 16384
}

Expand Down Expand Up @@ -447,12 +446,12 @@ func encodeNumericBinary(n Numeric, buf []byte) (newBuf []byte, err error) {

var wholeDigits, fracDigits []int16

for wholePart.Cmp(big0) != 0 {
for wholePart.Sign() != 0 {
wholePart.DivMod(wholePart, bigNBase, remainder)
wholeDigits = append(wholeDigits, int16(remainder.Int64()))
}

if fracPart.Cmp(big0) != 0 {
if fracPart.Sign() != 0 {
for fracPart.Cmp(big1) != 0 {
fracPart.DivMod(fracPart, bigNBase, remainder)
fracDigits = append(fracDigits, int16(remainder.Int64()))
Expand Down Expand Up @@ -681,7 +680,7 @@ func (scanPlanBinaryNumericToNumericScanner) Scan(src []byte, dst any) error {
if exp >= 0 {
for {
reduced.DivMod(accum, big10, remainder)
if remainder.Cmp(big0) != 0 {
if remainder.Sign() != 0 {
break
}
accum.Set(reduced)
Expand Down
Loading