Skip to content

Make RowsAffected faster #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackc merged 1 commit into from
Dec 27, 2025
Merged

Make RowsAffected faster #2455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions pgconn/pgconn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,25 +777,20 @@ func NewCommandTag(s string) CommandTag {
// RowsAffected returns the number of rows affected. If the CommandTag was not
// for a row affecting command (e.g. "CREATE TABLE") then it returns 0.
func (ct CommandTag) RowsAffected() int64 {
// Find last non-digit
idx := -1
// Parse the number from the end in a single pass.
var n int64
var mult int64 = 1

for i := len(ct.s) - 1; i >= 0; i-- {
if ct.s[i] >= '0' && ct.s[i] <= '9' {
idx = i
c := ct.s[i]
if c >= '0' && c <= '9' {
n += int64(c-'0') * mult
mult *= 10
} else {
break
}
}

if idx == -1 {
return 0
}

var n int64
for _, b := range ct.s[idx:] {
n = n*10 + int64(b-'0')
}

return n
}

Expand Down
Loading