tx: regression test for Rollback after mid-query connection close (#2557)#2591
Merged
Merged
Conversation
jackc
added a commit
that referenced
this pull request
Jun 30, 2026
tx: regression test for Rollback after mid-query connection close (#2557) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2559. That PR added pgconn.ErrConnClosed and a pgconn-level test, but #2557 was filed against the pgx.Tx layer and there's no test covering that path.
This adds one: begin a tx, cancel an Exec mid-flight so the underlying conn closes, then assert the first Rollback is errors.Is(err, pgconn.ErrConnClosed) and not ErrTxClosed, and a second Rollback returns ErrTxClosed. No production code change.
Tested against Postgres 17 with -race, -count=20, no flakes.