Split pybigtools lib.rs into submodules#91
Merged
jackh726 merged 12 commits intojackh726:masterfrom Oct 21, 2025
Merged
Conversation
Owner
|
Good idea, but looks like something got shuffled in the merge :) |
nvictus
force-pushed
the
refactor-pybt-lib
branch
from
2c40a09 to
c0addc0
Compare
nvictus
force-pushed
the
refactor-pybt-lib
branch
from
9fd5838 to
511719e
Compare
nvictus
force-pushed
the
refactor-pybt-lib
branch
from
511719e to
d7bf847
Compare
Collaborator
Author
|
Not sure what happened. Did it over again. Looks like it works now. I also added developer instructions in the pybigtools readme and updated the python linting and testing workflows in CI. |
Owner
|
Thanks @nvictus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pybigtools bindings are a bit unwieldy as a single rust module. I split the reader and writer pyo3 structs, errors, and querying utilities into separate modules to improve maintainability.