Skip to content

fix: Fixes an issue with strings that starts with numbers #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
photomattmills merged 1 commit into from
Feb 26, 2025
Merged

fix: Fixes an issue with strings that starts with numbers #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pdf417/number_compactor.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ defmodule PDF417.NumberCompactor do
end

def compactable?(part) do
String.length(part) > 13 && Integer.parse(part) != :error
String.length(part) > 13 && String.match?(part, ~r/^\d+$/)
end

def codeword, do: 902
Expand Down
10 changes: 9 additions & 1 deletion test/number_compactor_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,18 @@ defmodule PDF417.NumberCompactorTest do
assert NumberCompactor.compactable?("12345678912345")
end

test "returns false for strings" do
test "returns false for short strings" do
refute NumberCompactor.compactable?("asdf")
end

test "returns false for long strings" do
refute NumberCompactor.compactable?("stringgreaterthanthirteencharacters")
end

test "returns false for strings that does not represent a number" do
refute NumberCompactor.compactable?("123abcdefghijkl")
end

test "returns false for short numbers" do
refute NumberCompactor.compactable?("123")
end
Expand Down
Loading