Skip to content

fix: link peer dependencies for local-source plugins too #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyrcho wants to merge 1 commit into
base: v5
Choose a base branch
from
+10 −0
Open

fix: link peer dependencies for local-source plugins too #2503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions quartz/plugins/loader/gitLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,7 @@ export async function installPlugin(
if (options.verbose) {
console.log(styleText("cyan", `→`), `Plugin ${spec.name} already linked`)
}
linkPeerDependencies(pluginDir)
return { pluginDir, nativeDeps: collectNativeDeps(pluginDir) }
}
} catch {
Expand Down Expand Up @@ -479,6 +480,15 @@ export async function installPlugin(
console.log(styleText("green", `✓`), `Linked ${spec.name}`)
}

// Local sources skip the git-clone build path (and its
// linkPeerDependencies call in buildInstalledPlugin), so a local
// plugin that peer-depends on another @quartz-community/* plugin
// (e.g. a custom view registering against bases-page) would
// otherwise resolve a different module instance than the one the
// rest of Quartz uses, breaking any module-level singleton state
// (like a view-type registry) shared between them.
linkPeerDependencies(pluginDir)

return { pluginDir, nativeDeps: collectNativeDeps(pluginDir) }
}

Expand Down
Loading