build: add node-gyp to devDependencies to resolve sharp source-build failures - #2538
Open
abstraction wants to merge 1 commit into
Open
build: add node-gyp to devDependencies to resolve sharp source-build failures#2538abstraction wants to merge 1 commit into
abstraction wants to merge 1 commit into
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior
I hit a hard crash running
npm ion Node LTS. Turns out if you havelibvipsinstalled,sharpskips the prebuilt binaries. It tries to compile from source instead.Quartz already pulls in
node-addon-apias a dependency through@parcel/watcher(ref). Sharp finds it without an issue. Butnode-gypis missing entirely.This completely breaks setup if the user's system forces a source build.
Expected behavior
Users can run
npm iorpnpm iand get a working setup out of the box.Solution
I added
node-gyptodevDependencies. I leftnode-addon-apiout because@parcel/watcheralready brings it into the tree, and the sharp build succeeds with it as-is.Pulling in
node-gypadds some weight to the initial install. But it stops the setup from crashing for common dev environments (mac too, i guess).Environment