libclang 19.1.7 #292
Merged
libclang 19.1.7 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase your branch. I've fixed the failing CI pipeline. |
This didn't seem to be the point of the issue but caused the test to fail. Error message: Common.TranslateAssertError@tests/unit/issues/Issue8.d(14): Cannot compile source code. Errors: ---------------- /tmp/dstepZRUFDHDGRGxkGPVu.h:22:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
In some new clang versions, the name (cursor.spelling) of anonymous structs, unions and enums was set to an informative message instead of an empty string. I.e. "enum (unnamed at [declaration_file.h:48]" This fixes the errors that happen due to that in a backwards compatible way, since it still checks for empty spellings. This patch is possibly overeager in checking the cursor.spellings for these new special values, I haven't checked at every single location whether the check is necessary.
Inkrementator
force-pushed
the
brokentests
branch
from
bcec501 to
fc74e90
Compare
|
done |
jacob-carlborg
approved these changes
Mar 18, 2025
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix anonymous composites in clang 19.1.7
In some new clang versions, the name (cursor.spelling) of anonymous structs,
unions and enums was set to an informative message instead of an empty
string. I.e. "enum (unnamed at [declaration_file.h:48]"
This fixes the errors that happen due to that in a backwards compatible
way, since it still checks for empty spellings.