Stop returning requests objects #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove some impossible to test methods - Remove the constant usage of `.json()` to get values - Remove the constant need to check if "success" is True
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 97.74% 98.95% +1.21%
==========================================
Files 45 43 -2
Lines 2082 1912 -170
Branches 113 108 -5
==========================================
- Hits 2035 1892 -143
+ Misses 35 11 -24
+ Partials 12 9 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make it easier to use the library and made some opinionated changes.
All methods now will trigger an exception (
RocketBadStatusCodeException) if they fail that contains the failure message and status code. No more manual checking in your code. Methods will also return thejsonrepresentation of the response instead of the wholerequestsresponse object. If the object can't be converted to json for any reason, the return value is the raw text.Also on this refactor I decided to sunset some methods that we have not been able to automatically test for some time.
Those methods are:
Because these are breaking changes, the next version bump will be a major one. The previous version will no longer be maintained.