Skip to content

Conversation

@yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Oct 30, 2024

What this PR does

  • Extracts common k8s setup steps into a reusable action
  • Move install test into a separate job

Which issue this PR fixes

The CI testing of the chart does not cover installing 3rd party storage backends. PR #614 adds an extra test but either has to do it sequentially within the single job or replicate a lot of setup for another job / workflow. With this refactoring #614 would be able to add a new job to the existing workflow with minimal amount of boiler plate.

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro marked this pull request as ready for review October 30, 2024 19:46
@yurishkuro yurishkuro merged commit 1db9b63 into main Oct 31, 2024
3 checks passed
@yurishkuro yurishkuro deleted the share-setup branch October 31, 2024 14:59
hellspawn679 added a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
* Share setup sub-action in CI

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: mehul <[email protected]>
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 2, 2024
* Share setup sub-action in CI

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: mehul <[email protected]>

Update Chart.yaml

Signed-off-by: Pavel Nikolov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants