[jaeger] Add postUpgradeTasks to auto-bump chart version on dependency updates #693
Conversation
…gradeTasks Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
|
@copilot this is too complex. .github/scripts/update-jaeger-version.sh can be significantly simplified from step 4, just call the new script. There is no need for --print-only logic in the bumping script, we don't need update-jaeger-version to provide a dry-run only summary by itself. It can be structured as this:
We should also revisit all the outputs that .github/scripts/update-jaeger-version.sh writes to if git diff --exit-code "$CHART_PATH"; then and skips commits when no changes, so the script update-jaeger-version.sh should just be making changes to files, not signaling back to the workflow. |
Co-authored-by: yurishkuro <[email protected]>
Simplified the scripts as requested in commit 08fc6ff:
Net result: -81 lines, +24 lines across all files. Much simpler and easier to maintain! |
| ref: main | ||
|
|
||
| - name: 🔍 Check for new Jaeger version | ||
| id: check_version |
| if [[ "$BUMP_TYPE" == "minor" ]]; then | ||
| echo "Bumping chart minor version in ${CHART_PATH}..." | ||
| else | ||
| echo "Bumping chart patch version in ${CHART_PATH}..." | ||
| fi | ||
|
|
There was a problem hiding this comment.
| if [[ "$BUMP_TYPE" == "minor" ]]; then | |
| echo "Bumping chart minor version in ${CHART_PATH}..." | |
| else | |
| echo "Bumping chart patch version in ${CHART_PATH}..." | |
| fi |
| # --- 1. Verify Chart.yaml exists --- | ||
| if [[ ! -f "$CHART_PATH" ]]; then | ||
| echo "Error: Chart file '${CHART_PATH}' not found. Exiting." | ||
| exit 1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
| # --- 1. Verify Chart.yaml exists --- | |
| if [[ ! -f "$CHART_PATH" ]]; then | |
| echo "Error: Chart file '${CHART_PATH}' not found. Exiting." | |
| exit 1 | |
| fi |
|
@copilot address review comments (remove unnecessary code) and bump the chart patch number to make sure CI passes (bump is required for every change) |
Co-authored-by: yurishkuro <[email protected]>
Done in commit 270daab:
All tests passing. |
What this PR does
Automates chart version bumping when Renovatebot updates dependencies. Previously required manual version updates; now patch version increments automatically (4.1.0 → 4.1.1) when dependencies change.
Changes:
.github/scripts/bump-chart-version.sh: Clean, focused 89-line script supporting patch/minor bumps with--bump-minorand--dry-runflagsrenovate.json: AddedpostUpgradeTasksto run bump script after dependency upgradesupdate-jaeger-version.sh: Simplified to 5 clear steps - determines if update needed, prints summary, updates appVersion, and calls bump-chart-version.sh.github/workflows/update-jaeger-version.yamlto extract version information from Chart.yaml directly instead of relying on script outputsVersion bump strategy:
Both now use the same script, just different flags.
Simplifications based on review feedback:
--print-onlyflag from bump-chart-version.shGITHUB_OUTPUTwrites from update-jaeger-version.sh (workflow handles signaling viagit diff)Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format,will close that issue when PR gets merged)
Checklist
[jaeger]or[jaeger-operator])Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.