[jaeger] Fix #700 and AIO ingress bugs #701
Open
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd fix other AIO bugs (jaegertracing#700) Update ingress yamls to remove unsupported supportsIngressClassname and fix other AIO bugs - [X] [DCO](https://github.com/jaegertracing/helm-charts/blob/main/CONTRIBUTING.md#sign-off-your-work) signed - [X] Commits are [GPG signed](https://docs.github.com/en/github/authenticating-to-github/about-commit-signature-verification) - [X] Chart Version bumped - [X] Title of the PR starts with chart name (`[jaeger]` or `[jaeger-operator]`) (NOT NEEDED) - [X] README.md has been updated to match version/contain new values Signed-off-by: Greg Olmstead <[email protected]>
maynardflies
requested review from
naseemkullah and
pavelnikolov
as code owners
Signed-off-by: Greg Olmstead <[email protected]>
yurishkuro
reviewed
Dec 16, 2025
| - path: / | ||
| pathType: {{ default "ImplementationSpecific" $.Values.allInOne.ingress.pathType }} | ||
| backend: {{- include "common.ingress.backend" (dict "serviceName" (include "jaeger.query.name" $) "servicePort" 16686 "context" $) | nindent 14 }} | ||
| backend: {{- include "common.ingress.backend" (dict "serviceName" (printf "%s-query" (include "jaeger.fullname" $)) "servicePort" 16686 "context" $) | nindent 14 }} |
Author
There was a problem hiding this comment.
Lifted this from https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/allinone-query-svc.yaml#L5 since that's the service it should be referencing
Contributor
There was a problem hiding this comment.
@yurishkuro these changes are correct , i have tested in local cluster , we can merge this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ingress yamls to remove unsupported supportsIngressClassname and fix other AIO bugs (resolves #700)
What this PR does
Update ingress yamls to remove unsupported supportsIngressClassname and fix other AIO bugs
Checklist
signed
signed
[jaeger]or[jaeger-operator])