[jaeger] Major refactoring of templates to simplify

[jkowall]

[jaeger] Major refactoring for Jaeger v2

Summary

This PR modernizes the Jaeger Helm chart for Jaeger v2, which is built on the OpenTelemetry Collector framework. It removes legacy v1 components and consolidates to a single deployment model with simplified, more maintainable templates.

Breaking Changes ⚠️

Values Schema Changes

• allInOne: → jaeger: - The main deployment section has been renamed
• schema: section removed - Cassandra schema job no longer needed (Jaeger v2 handles schema internally)
• hotrod: section removed - Demo app removed from chart
• Storage configuration moved to config.extensions.jaeger_storage using native OTel Collector syntax

Migration Guide

# Before (v1)
allInOne:
  image:
    tag: "1.x.x"

# After (v2)
jaeger:
  image:
    tag: "2.13.0"

For storage configuration, see the updated README.md examples.

Changes

Templates Removed (Legacy v1 Components)

• allinone-agent-svc.yaml, allinone-collector-svc.yaml, allinone-query-svc.yaml - Separate services
• cassandra-schema-job.yaml & cassandra-schema-sa.yaml - Schema initialization
• elasticsearch-secret.yaml - ES secret management
• es-index-cleaner-cronjob.yaml, es-rollover-cronjob.yaml, es-lookback-cronjob.yaml & their SA files - Now in es-maintenance.yaml
• hotrod-*.yaml - Demo application
• spark-sa.yaml - Merged into spark-dependencies.yaml

Templates Renamed

• allinone-deploy.yaml → jaeger-deploy.yaml
• allinone-sa.yaml → jaeger-sa.yaml
• allinone-ing.yaml → jaeger-ing.yaml
• allinone-configmap.yaml → jaeger-configmap.yaml
• spark-cronjob.yaml → spark-dependencies.yaml

Templates Added/Consolidated

• service.yaml - Unified service exposing all ports (agent, collector, query, OTLP)
• es-maintenance.yaml - Consolidated ES maintenance jobs with their ServiceAccounts

Helper Functions Cleaned Up (_helpers.tpl)

Removed ~100 lines of unused helpers including schema, hotrod, and legacy ES helpers.

values.yaml Improvements

• Clear section headers distinguishing storage.* (connection settings) from top-level cassandra:/elasticsearch: (subchart provisioning)
• Removed deprecated/unused settings
• Added documentation comments throughout

Documentation

• Completely rewritten README.md for Jaeger v2
• Added "Overriding the Jaeger Version" section
• Added Spark Dependencies README link
• Clarified Cassandra is external-only

Bug Fixes

• Fixed duplicate annotations block in service.yaml
• Fixed storage-configmap.yaml to render Values.config directly

Stats

• 32 files changed
• +700 insertions, -1,696 deletions (net ~1,000 lines removed)

Testing

• helm lint charts/jaeger passes
• make test passes (deploys to local k8s)
• Templates render correctly for memory, elasticsearch, and cassandra storage types

Checklist

• Chart version bumped (4.1.5 → 4.2.0)
• README.md updated
• values.yaml documented
• .gitignore updated (added .vscode/)
• All commits signed off (DCO)

[jkowall]

There were still CI issues, but this push should fix it

CI Fix - Restore Provisioned Elasticsearch Logic & Stability

• Goal: Fix CI failure where Jaeger failed to connect to the provisioned Elasticsearch instance.
• Problem 1: Removing the bespoke DSL inadvertently removed the logic that wired up provisionDataStore.elasticsearch=true in _helpers.tpl.
• Fix 1:
  • Re-introduced elasticsearch.env helper in _helpers.tpl to auto-configure ES_SERVER_URLS.
  • Updated storage.env and es-maintenance.yaml to use this logic.
• Problem 2: CI Timeout and Configuration Errors.
  • values.yaml contained an invalid enabled: false field in volumeClaimTemplate causing K8s warnings.
  • The CI environment was failing the Elasticsearch Readiness Probe due to short timeouts (1s) and slow runners.
  • Jaeger v2 (used in all-in-one) failed to start with empty backend configuration error because storage-configmap.yaml was generating empty blocks for primary_store and archive_store.
• Fix 2:
  • Removed invalid configuration from values.yaml.
  • Updated Makefile to increase timeout to 10s and increase initialDelaySeconds and failureThreshold for Elasticsearch readiness probes.
  • Updated storage-configmap.yaml to fully restore the automatic configuration of primary_store and archive_store when provisionDataStore.elasticsearch is enabled.
  • Critical Fix: Modified storage-configmap.yaml to embed credentials directly in server_urls (e.g., https://user:pass@host:port) because Jaeger v2 configuration rejection of username/password keys and failed to respect environment variable overrides when a config file was present. This ensures successful connection and authentication.

[Copilot]

Pull request overview

This PR introduces a major refactoring of the Jaeger Helm chart, transitioning from version 4.1.5 to what is described as version 5.0.0 in the PR description. The refactoring simplifies the chart architecture by consolidating components and removing deprecated features to provide a more streamlined deployment experience.

Key Changes:

• Unified deployment model using only the "All-in-One" architecture, removing split deployment options
• Removal of HotROD example application and legacy Elasticsearch DSL configuration
• Template consolidation for Elasticsearch maintenance jobs, Spark dependencies, and Cassandra schema into fewer files

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
charts/jaeger/Chart.yaml	Chart version bump to 4.2.0 (though PR description indicates 5.0.0)
charts/jaeger/values.yaml	Removed hotrod, schema, and legacy elasticsearch configuration sections; updated elasticsearch volumeClaimTemplate
charts/jaeger/README.md	Completely rewritten documentation for v4.2.0 focusing on All-in-One architecture
charts/jaeger/templates/NOTES.txt	Updated with experimental warning and simplified installation notes
charts/jaeger/templates/service.yaml	New unified service consolidating agent, collector, and query services
charts/jaeger/templates/es-maintenance.yaml	New consolidated template combining index cleaner, rollover, and lookback CronJobs with their ServiceAccounts
charts/jaeger/templates/spark-dependencies.yaml	Consolidated Spark CronJob with ServiceAccount; added conditional guards for volumeMounts
charts/jaeger/templates/_helpers.tpl	Removed legacy helper functions (elasticsearch.client.url, hotrod helpers, schema helpers); refactored elasticsearch.env helper
charts/jaeger/templates/storage-configmap.yaml	Updated to use helper functions for configuration sections and added cassandra storage type condition
charts/jaeger/templates/hotrod-*.yaml	Removed all HotROD related templates (deployment, service, ingress, service account)
charts/jaeger/templates/es-*-sa.yaml	Removed separate ServiceAccount files for ES maintenance jobs (now in es-maintenance.yaml)
charts/jaeger/templates/es-*-cronjob.yaml	Removed separate CronJob files for ES maintenance (now in es-maintenance.yaml)
charts/jaeger/templates/allinone-*-svc.yaml	Removed separate agent, collector, and query services (replaced by unified service.yaml)
charts/jaeger/templates/cassandra-schema-*.yaml	Removed Cassandra schema job and ServiceAccount (Jaeger v2 handles schema internally)
charts/jaeger/templates/elasticsearch-secret.yaml	Removed Elasticsearch secret template
Makefile	Updated test-es target with additional elasticsearch readiness probe configuration
.vscode/settings.json	Added VS Code configuration file

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.