[jaeger] chore: adding the ability to set labels and annotations on the services for the allinone quer, agent and collector #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for the allinone quer, agent and collector Signed-off-by: Drew Hudson-Viles <[email protected]>
drew-viles
requested review from
naseemkullah and
pavelnikolov
as code owners
drew-viles
changed the title
drew-viles
changed the title
Member
|
please rebase, there was a large upgrade in v4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This adds new values so that a user can pass additional labels and annotations to the Services for query,agent and collector.
Checklist
[jaeger]or[jaeger-operator])