[jaeger] Add extraSecretMounts to jaeger

[DevErenOzcan]

Description

This PR introduces the extraSecretMounts capability to the Jaeger deployment chart.

Currently, users relying on external secret management tools like HashiCorp Vault via the Secrets Store CSI Driver face limitations because there is no native way to attach these external volumes directly to the Jaeger pods without complex workarounds (like creating auxiliary pause pods).

Similar to the implementation in kube-prometheus-stack, this feature allows users to easily define secret mounts in their values.yaml, and the template automatically handles both the volumes and volumeMounts configurations.

Related Issues:

• Fixes [Bug]: Missing support for extraSecretMounts #735
• Resolves [Bug]: Add extraVolumes/extraVolumeMounts support to jaeger deployment #737

Changes Made

• Added extraSecretMounts block parsing to jaeger/templates/jaeger/jaeger-deploy.yaml (handles both volumeMounts and volumes).
• Added an empty extraSecretMounts: [] list to jaeger/values.yaml to ensure backward compatibility and serve as documentation.

How to Test

You can test this by adding the following block to your values.yaml and running helm template:

jaeger:
  extraSecretMounts:
    - name: secrets-store-inline
      mountPath: "/mnt/secrets-store"
      readOnly: true
      csi:
        driver: secrets-store.csi.k8s.io
        readOnly: true
        volumeAttributes:
          secretProviderClass: "vault-jaeger-creds"

[Copilot]

Pull request overview

This PR adds an extraSecretMounts values hook to the Jaeger Deployment template so users can attach additional mounted content (notably Secrets Store CSI volumes) to the Jaeger pod without workarounds.

Changes:

• Added jaeger.extraSecretMounts to values.yaml (default empty list).
• Rendered additional volumeMounts and corresponding volumes entries in jaeger/templates/jaeger/jaeger-deploy.yaml based on jaeger.extraSecretMounts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
charts/jaeger/values.yaml	Introduces the new jaeger.extraSecretMounts values key with an empty default.
charts/jaeger/templates/jaeger/jaeger-deploy.yaml	Wires jaeger.extraSecretMounts into the Jaeger Deployment’s volumeMounts and volumes (CSI-focused).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Because volumes: is always emitted but all items are conditional, the rendered manifest can end up with volumes: null when no volumes are configured. Other templates in this chart avoid this by conditionally emitting the entire volumes: block (e.g., templates/spark/spark-dependencies.yaml). Consider applying the same pattern here (wrap volumes: + entries in an if, or render volumes: []).

[Copilot]

This new extraSecretMounts value is placed directly under the comment block for “command line arguments / CLI flags”, but it configures pod volume mounts rather than CLI args. Please move it to a more appropriate subsection (or add a short comment explaining its structure: name, mountPath, optional readOnly, and csi/secret fields) so users don’t miss or misinterpret it.

[Copilot]

extraSecretMounts is used by other chart components (spark / es-* cronjobs) with a secretName-based schema that renders secret: volumes, but here it assumes a CSI-backed volume (csi:). Reusing the same values key for different structures across the chart is likely to confuse users. Consider supporting both secret: and csi: volume sources in one schema, or renaming this field to something CSI-specific to avoid an ambiguous API.

[Copilot]

Because volumeMounts: is always emitted but all items are conditional, the rendered manifest can end up with volumeMounts: null when no mounts are configured. Other templates in this chart avoid this by conditionally emitting the entire volumeMounts: block (e.g., templates/spark/spark-dependencies.yaml). Consider applying the same pattern here (wrap volumeMounts: + entries in an if, or render volumeMounts: []).

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time.