Skip to content

Add port 8889 #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agueijo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add port 8889 #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/jaeger/templates/jaeger/jaeger-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ spec:
protocol: TCP
- containerPort: 8888
protocol: TCP
- containerPort: 8889
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing port 8888 and other ports in this file likely have a name field to identify their purpose (e.g., for use in Service selectors or readability). This new port entry is missing a name field. Consider adding a descriptive name such as span-metrics to be consistent with the other port definitions and to make it clear what this port is used for.

Suggested change
- containerPort: 8889
- containerPort: 8889
name: span-metrics

Copilot uses AI. Check for mistakes.
protocol: TCP
livenessProbe:
failureThreshold: 5
httpGet:
Expand Down
Loading