[jaeger] Checksum user/ui config to restart all-in-one on change#765
Open
oysteingl wants to merge 1 commit into
Open
[jaeger] Checksum user/ui config to restart all-in-one on change#765oysteingl wants to merge 1 commit into
oysteingl wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR ensures Jaeger pods roll out when rendered config templates change, and increments the Helm chart version accordingly.
Changes:
- Add checksum annotations to the Jaeger Deployment pod template to trigger rolling updates on config changes.
- Bump chart version from
4.11.0to4.11.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/jaeger/templates/jaeger/jaeger-deploy.yaml | Adds checksum annotations for user/ui config templates to force Deployment rollouts on changes |
| charts/jaeger/Chart.yaml | Increments chart version to reflect the behavior change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
38
to
42
| annotations: | ||
| checksum/user-config: {{ include (print $.Template.BasePath "/jaeger/jaeger-user-config.yaml") . | sha256sum }} | ||
| checksum/ui-config: {{ include (print $.Template.BasePath "/jaeger/jaeger-ui-config.yaml") . | sha256sum }} | ||
| prometheus.io/port: "8888" | ||
| prometheus.io/scrape: "true" |
The all-in-one Deployment mounts the user-config and ui-config ConfigMaps via subPath, and its pod template has no checksum annotation. So when .Values.userconfig or .Values.uiconfig changes, the ConfigMaps update but the running pod keeps the old config and is never restarted. Add checksum/user-config and checksum/ui-config annotations to the pod template (same approach jaegertracing#246 used for the query UI config) so the all-in-one pod rolls and reloads when either config changes. Bumps the jaeger chart to 4.11.1. Signed-off-by: ogl <ogl@dips.no>
oysteingl
force-pushed
the
jaeger-allinone-checksum-config
branch
from
b589b55 to
184d32a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The all-in-one Deployment (
templates/jaeger/jaeger-deploy.yaml) mounts theuser-configandui-configConfigMaps viasubPath, and its pod template carries no checksum annotation. As a result, when.Values.userconfigor.Values.uiconfigchanges, Helm/ArgoCD updates the ConfigMaps but the running pod keeps the old config and is never restarted (subPath mounts don't receive in-place updates either).This adds
checksum/user-configandchecksum/ui-configannotations to the pod template, so a change to either config rolls the pod and reloads the new config. This mirrors the approach #246 took for the query UI config, now applied to the v2 all-in-one deployment.Bumps the
jaegerchart to4.11.1(per the immutability/versioning policy).Testing
helm lintpasses.helm templaterenders both annotations to concrete SHA256 values in the pod template.checksum/user-configchanges whenuserconfigchanges (pod will roll); unchanged config yields a stable checksum (no spurious restarts).Checklist
[jaeger])