feat: generate go code zipkincore.thrift

Signed-off-by: nabil salah <[email protected]>

.github/workflows/ci-unit-tests.yml

@@ -53,3 +53,6 @@ jobs:
 
     - name: Test code gen
       run: make test-code-gen
+
+    - name: Verify Thrift types are up to date
+      run: make thrift && git diff --name-status --exit-code

Makefile

@@ -27,6 +27,7 @@ THRIFT_CMD=$(THRIFT) -o /data $(THRIFT_GEN)
 
 THRIFT_FILES=agent.thrift jaeger.thrift sampling.thrift zipkincore.thrift crossdock/tracetest.thrift \
 	baggage.thrift dependency.thrift aggregation_validator.thrift
+THRIFT_GEN_DIR=thrift-gen
 
 .PHONY: test-code-gen
 test-code-gen: thrift swagger-validate protocompile proto proto-zipkin
@@ -43,7 +44,10 @@ clean:
 	rm -rf coverage.txt
 
 .PHONY: thrift
-thrift:	thrift-image clean $(THRIFT_FILES)
+thrift: thrift-image clean
+	[ -d $(THRIFT_GEN_DIR) ] || mkdir $(THRIFT_GEN_DIR)
+	$(THRIFT) -o /data --gen go:$(THRIFT_GO_ARGS) -out /data/$(THRIFT_GEN_DIR) /data/thrift/zipkincore.thrift
+	rm -rf thrift-gen/*/*-remote thrift-gen/*/*.bak
 
 $(THRIFT_FILES):
 	@echo Compiling $@

go.mod

@@ -14,6 +14,7 @@ require (
 )
 
 require (
+	github.com/apache/thrift v0.21.0 // indirect
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/kr/pretty v0.3.1 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect

go.sum

@@ -1,3 +1,5 @@
+github.com/apache/thrift v0.21.0 h1:tdPmh/ptjE1IJnhbhrcl2++TauVjy242rkV/UzJChnE=
+github.com/apache/thrift v0.21.0/go.mod h1:W1H8aR/QRtYNvrPeFXBtobyRkd0/YVhTc6i07XIAgDw=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=